Test: Add gas costs to /gas-prices endpoint #1349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nicholaspai <[email protected]>
nicholaspai
requested review from
mrice32,
dohaki,
james-a-morris and
pxrl
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nicholaspai
commented
Jan 4, 2025
| Number(chainId) | ||
| ); | ||
| return relayerFeeCalculatorQueries.getGasCosts( | ||
| buildDepositForSimulation(depositArgs), |
There was a problem hiding this comment.
This should parallel how the /iimits endpoint computes the gasFeePercent today:
- Passes the
gasPricecomputed usinggetMaxFeePerGasand thegasUnitspassed from agetGasCosts()call withomitMarkup = trueinto getRelayerFeeDetails which ultimately calls the SDK'sgetGasCostsfunction
nicholaspai
changed the title
james-a-morris
requested changes
Jan 6, 2025
…gas prices Gas prices will be more accurate for OP stack chains and also for Zora which was mistakenly removed from the OPStack family prior to this SDK bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not designed to be merged. I only want to print out the current gas fee computation components on the production API to compare against those with #1339
Signed-off-by: nicholaspai [email protected]