Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support transfer with auth #1341

Merged
merged 24 commits into from
Jan 6, 2025
Merged

support transfer with auth #1341

merged 24 commits into from
Jan 6, 2025

Conversation

gsteenkamp89
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 11:26am
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 11:26am

@gsteenkamp89 gsteenkamp89 requested a review from dohaki December 20, 2024 14:38
@gsteenkamp89 gsteenkamp89 mentioned this pull request Dec 20, 2024
Closed
Base automatically changed from support-permit-swap to swap-endpoint December 20, 2024 14:53
dohaki
dohaki reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few remarks and questions

api/_transfer-with-auth.ts Outdated Show resolved Hide resolved
api/relay/_utils.ts Outdated Show resolved Hide resolved
scripts/tests/swap-auth.ts Outdated Show resolved Hide resolved
@gsteenkamp89 gsteenkamp89 requested a review from dohaki January 3, 2025 16:49
dohaki
dohaki approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsteenkamp89 gsteenkamp89 merged commit 87a0f44 into swap-endpoint Jan 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dohaki dohaki dohaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteenkamp89 @dohaki