Add scaffolding for config unpacking #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
…o pablo/relayer-config
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Co-authored-by: James Morris, MS <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
api/relayer-config.ts
Outdated
Comment on lines
56
to
60
| if (!RelayerFillLimitsSchema.is(message)) { | ||
| return response | ||
| .status(400) | ||
| .json({ message: "Invalid configuration payload" }); | ||
| } |
There was a problem hiding this comment.
We should assert here - we should only send status in the try catch. See https://github.com/across-protocol/frontend-v2/blob/98f3e618c61607870aabc8a625570481413c955f/api/account-balance.ts
md0x
approved these changes
Dec 11, 2024
james-a-morris
approved these changes
Dec 11, 2024
Base automatically changed from
pablo/relayer-config-auth
to
epic/relayer-config
December 11, 2024 22:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.