feat(api): relayer config auth #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
…o pablo/relayer-config
Signed-off-by: Pablo Maldonado <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Pablo Maldonado <[email protected]>
Co-authored-by: James Morris, MS <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
pxrl
reviewed
Dec 11, 2024
api/_exclusivity/utils.ts
Outdated
| "0x9A8f92a830A5cB89a3816e3D267CB7791c16b04D", // dev wallet | ||
| ]; | ||
|
|
||
| export const getRelayerFromSignature = async ( |
There was a problem hiding this comment.
verifyMessage() isn't async; can we drop the async here ?
Suggested change
| export const getRelayerFromSignature = async ( | |
| export const getRelayerFromSignature = ( |
pxrl
reviewed
Dec 11, 2024
pxrl
reviewed
Dec 11, 2024
api/relayer-config.ts
Outdated
Comment on lines
17
to
20
| const { timestamp, ...restOfMessage } = JSON.parse(message); | ||
| if (!isTimestampValid(timestamp, MAX_MESSAGE_AGE_SECONDS)) { | ||
| return response.status(400).json({ message: "Message too old" }); | ||
| } |
There was a problem hiding this comment.
I think the timestamp would need to be covered by the signature, otherwise it doesn't protect against replay.
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Co-authored-by: James Morris, MS <[email protected]>
Co-authored-by: James Morris, MS <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
james-a-morris
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.