Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uniswap v3 exact output support + UniversalSwapAndBridge #1268

Merged
merged 12 commits into from
Nov 10, 2024
Merged

feat: uniswap v3 exact output support + UniversalSwapAndBridge #1268

merged 12 commits into from
Nov 10, 2024

Conversation

dohaki
Copy link
Contributor

@dohaki dohaki commented Nov 8, 2024 •
edited
Loading

  • Adds generic helper method that allows us to query a Uniswap quote for EXACT_OUTPUT
  • Migrates existing SwapAndBridge logic to newly deployed UniversalSwapAndBridge contracts

Closes ACX-3280

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:13pm
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:13pm

@dohaki dohaki changed the title feat: uniswap v3 exact output support feat: uniswap v3 exact output support + UniversalSwapAndBridge Nov 8, 2024
@linear Linear
Copy link

linear bot commented Nov 8, 2024

ACX-3280 [uni] Implement function to return quote for `minOutputAmount`

@dohaki dohaki requested review from gsteenkamp89, bmzig and pxrl November 8, 2024 08:29
bmzig
bmzig reviewed Nov 8, 2024
View reviewed changes
scripts/generate-routes.ts Outdated Show resolved Hide resolved
bmzig
bmzig approved these changes Nov 8, 2024
View reviewed changes
Copy link

@bmzig bmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. AlphaRouter seems really handy.

@dohaki dohaki merged commit 9c39be4 into swap-endpoint Nov 10, 2024
9 checks passed
@dohaki dohaki deleted the uniswap-v3-exact-output-support branch November 10, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmzig bmzig bmzig approved these changes

@gsteenkamp89 gsteenkamp89 Awaiting requested review from gsteenkamp89 gsteenkamp89 is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dohaki @bmzig