feat(multicall): add for alephzero and zksync #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
requested review from
dohaki,
gsteenkamp89,
melisaguevara and
amateima
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dohaki
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Looks good! As an FYI, we seem to have two different ways of resolving a multicall3 address. The function covered in this PR is only used for L1/Mainnet multicalls. But we also use multicall here https://github.com/across-protocol/frontend-v2/blob/a2a9e4a4263cac6eac3085674ff650c6e85c62c3/api/_utils.ts#L1057. But it relies on the correct addresses upstream in the SDK https://github.com/across-protocol/sdk/blob/b43acb896801647dce6bdea82dfad90b908f7224/src/utils/Multicall.ts#L19
james-a-morris
merged commit 424454d
into
james/acx-2766-update-frontend-dapp
9 checks passed
james-a-morris
added a commit
that referenced
this pull request
Nov 14, 2024
Signed-off-by: james-a-morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AlephZero multicall address. Also added ZKSync since it does not follow the standard Multicall3 address call