Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix casing of zksync logo served from /chains #1262

Merged
merged 4 commits into from
Oct 31, 2024
Merged

fix casing of zksync logo served from /chains #1262

merged 4 commits into from
Oct 31, 2024

Conversation

gsteenkamp89
Copy link
Contributor

@gsteenkamp89 gsteenkamp89 commented Oct 29, 2024 •
edited
Loading

closes ACX-2707

  • find the relative path of the logo in chainConfig and resolves it. testnet chains do not have duplicate assets so this will direct base-sepolia to base/assets/logo.svg.
  • directories for multi word names use dashes (-) as separator, while we export the chainConfig map keys with underscores. when resolving the path we need to replace underscores with dashes. this fixes the zksync logo resolution

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:50am
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:50am

@gsteenkamp89 gsteenkamp89 changed the title better numeric keyboard on mobile fix casing of zksync logo served from /chains Oct 29, 2024
@gsteenkamp89 gsteenkamp89 marked this pull request as ready for review October 30, 2024 12:47
@gsteenkamp89 gsteenkamp89 requested a review from dohaki October 30, 2024 12:47
@linear Linear
Copy link

linear bot commented Oct 30, 2024

ACX-2707 Bug: chain logo for zkSync does not resolve

dohaki
dohaki reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a comment on input type though

src/components/AmountInput/AmountInput.tsx Outdated Show resolved Hide resolved
@gsteenkamp89 gsteenkamp89 merged commit 3ae445a into master Oct 31, 2024
8 of 9 checks passed
@gsteenkamp89 gsteenkamp89 deleted the fix/zk-sync-logo branch October 31, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dohaki dohaki dohaki approved these changes

@james-a-morris james-a-morris Awaiting requested review from james-a-morris james-a-morris is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteenkamp89 @dohaki