Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use separate fill times json for exclusivity #1228

Merged
merged 4 commits into from
Oct 4, 2024
Merged

feat: use separate fill times json for exclusivity #1228

merged 4 commits into from
Oct 4, 2024

Conversation

dohaki
Copy link
Contributor

@dohaki dohaki commented Oct 1, 2024

Closes ACX-2833

@linear Linear
Copy link

linear bot commented Oct 1, 2024

ACX-2833 api: Freeze p75 times as at 2024-09-30

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 8:19am
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 8:19am

pxrl
pxrl reviewed Oct 1, 2024
View reviewed changes
api/_timings.ts Show resolved Hide resolved
pxrl
pxrl reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dohaki Does this PR need to consider the fixes that James prepared in this PR from 2 weeks ago? It was unfortunately never merged.

@dohaki
Copy link
Contributor Author

dohaki commented Oct 2, 2024

@dohaki Does this PR need to consider the fixes that James prepared in this PR from 2 weeks ago? It was unfortunately never merged.

Yea that's a good point. I will ping @james-a-morris about this.

@dohaki dohaki requested a review from pxrl October 2, 2024 14:21
@dohaki dohaki merged commit 38a081e into master Oct 4, 2024
9 checks passed
@dohaki dohaki deleted the use-separate-exclusivity-fill-times branch October 4, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmzig bmzig bmzig approved these changes

@gsteenkamp89 gsteenkamp89 Awaiting requested review from gsteenkamp89 gsteenkamp89 is a code owner

@james-a-morris james-a-morris Awaiting requested review from james-a-morris james-a-morris is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dohaki @bmzig @pxrl