feat(API): Align limits and suggested-fees relayerFeeDetails computations #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Add the following optional parameters to `/limits` to make it possible to compute the exact same limits in suggested fees: - message - recipient - relayer - amount This way the `/suggested-fees` endpoint can query `/limits` using those parameters so it doesn't need to recompute `relayerFeeDetails()` which might return very different values. I believe this also removes the need for `relayerFeeDetails` to compute the `isAmountTooLow` boolean anymore.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This might slow down suggested-fees too much since limits won't be cached nearly as much (if at all) |
dohaki
reviewed
Sep 8, 2024
dohaki
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following optional parameters to
/limitsto make it possible to compute the exact same limits in suggested fees:This way the
/suggested-feesendpoint can query/limitsusing those parameters so it doesn't need to recomputerelayerFeeDetails()which might return very different values.I believe this also removes the need for
relayerFeeDetailsto compute theisAmountTooLowboolean anymore.