fixup

across-protocol · Sep 6, 2024 · 8af4b05 · 8af4b05
1 parent 279efc3
commit 8af4b05
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 19 deletions.
diff --git a/api/_utils.ts b/api/_utils.ts
@@ -613,10 +613,10 @@ export const getRelayerFeeDetails = async (
     originChainId: number;
     destinationChainId: number;
     recipientAddress: string;
+    message?: string;
+    relayerAddress?: string;
   },
   tokenPrice?: number,
-  message?: string,
-  relayerAddress?: string,
   gasPrice?: sdk.utils.BigNumberish,
   gasUnits?: sdk.utils.BigNumberish
 ): Promise<sdk.relayFeeCalculator.RelayerFeeDetails> => {
@@ -627,6 +627,8 @@ export const getRelayerFeeDetails = async (
     originChainId,
     destinationChainId,
     recipientAddress,
+    message,
+    relayerAddress,
   } = deposit;
   const relayFeeCalculator = getRelayerFeeCalculator(destinationChainId, {
     relayerAddress,
@@ -646,7 +648,7 @@ export const getRelayerFeeDetails = async (
       sdk.utils.isMessageEmpty(message),
       relayerAddress,
       tokenPrice,
-      gasPrice, // FIXME: We need properly cache the gas price before this can be used reliably
+      gasPrice,
       gasUnits
     );
   } catch (err: unknown) {

diff --git a/api/limits.ts b/api/limits.ts
@@ -112,18 +112,19 @@ const handler = async (
       },
     ];
 
+    const relayerAddress = getDefaultRelayerAddress(
+      destinationChainId,
+      l1Token.symbol
+    );
     const depositArgs = {
       amount: ethers.BigNumber.from("10").pow(l1Token.decimals),
       inputToken: inputToken.address,
       outputToken: outputToken.address,
       recipientAddress: DEFAULT_SIMULATED_RECIPIENT_ADDRESS,
       originChainId: computedOriginChainId,
       destinationChainId,
+      relayerAddress,
     };
-    const relayerAddress = getDefaultRelayerAddress(
-      destinationChainId,
-      l1Token.symbol
-    );
 
     const [tokenPriceNative, _tokenPriceUsd, latestBlock, gasPrice, gasUnits] =
       await Promise.all([
@@ -147,14 +148,7 @@ const handler = async (
       transferRestrictedBalances,
       fullRelayerMainnetBalances,
     ] = await Promise.all([
-      getRelayerFeeDetails(
-        depositArgs,
-        tokenPriceNative,
-        undefined,
-        getDefaultRelayerAddress(destinationChainId, l1Token.symbol),
-        gasPrice,
-        gasUnits
-      ),
+      getRelayerFeeDetails(depositArgs, tokenPriceNative, gasPrice, gasUnits),
       callViaMulticall3(provider, multiCalls, {
         blockTag: latestBlock.number,
       }),

diff --git a/api/suggested-fees.ts b/api/suggested-fees.ts
@@ -213,6 +213,8 @@ const handler = async (
       recipientAddress: recipient,
       originChainId: computedOriginChainId,
       destinationChainId,
+      message,
+      relayerAddress: relayer,
     };
 
     const [
@@ -221,6 +223,7 @@ const handler = async (
       tokenPriceUsd,
       limits,
       gasPrice,
+      gasUnits,
     ] = await Promise.all([
       callViaMulticall3(provider, multiCalls, { blockTag: quoteBlockNumber }),
       getCachedTokenPrice(l1Token.address, baseCurrency),
@@ -232,7 +235,10 @@ const handler = async (
         destinationChainId
       ),
       getCachedGasPrice(destinationChainId),
-      getCachedFillGasUsage(depositArgs, { relayerAddress: relayer }),
+      // Only use cached fill gas usage if message is empty
+      sdk.utils.isMessageEmpty(message)
+        ? undefined
+        : getCachedFillGasUsage(depositArgs, { relayerAddress: relayer }),
     ]);
     const quoteTimestamp = parseInt(_quoteTimestamp.toString());
 
@@ -266,9 +272,8 @@ const handler = async (
     const relayerFeeDetails = await getRelayerFeeDetails(
       depositArgs,
       tokenPrice,
-      message,
-      relayer,
-      gasPrice
+      gasPrice,
+      gasUnits
     );
 
     const skipAmountLimitEnabled = skipAmountLimit === "true";