-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(svm): format docstrings #853
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Unchanged files with check annotations Beta
address public constant L1_DAI = 0x6B175474E89094C44Da98b954EedeAC495271d0F; | ||
// This address on L2 receives extra ETH that is left over after relaying a message via the inbox. | ||
address public immutable L2_REFUND_L2_ADDRESS; | ||
Check warning on line 46 in contracts/chain-adapters/Arbitrum_Adapter.sol
|
||
// Inbox system contract to send messages to Arbitrum. Token bridges use this to send tokens to L2. | ||
// https://github.com/OffchainLabs/nitro-contracts/blob/f7894d3a6d4035ba60f51a7f1334f0f2d4f02dce/src/bridge/Inbox.sol | ||
ArbitrumL1InboxLike public immutable L1_INBOX; | ||
Check warning on line 50 in contracts/chain-adapters/Arbitrum_Adapter.sol
|
||
// Router contract to send tokens to Arbitrum. Routes to correct gateway to bridge tokens. Internally this | ||
// contract calls the Inbox. | ||
// Generic gateway: https://github.com/OffchainLabs/token-bridge-contracts/blob/main/contracts/tokenbridge/ethereum/gateway/L1ArbitrumGateway.sol | ||
ArbitrumL1ERC20GatewayLike public immutable L1_ERC20_GATEWAY_ROUTER; | ||
Check warning on line 55 in contracts/chain-adapters/Arbitrum_Adapter.sol
|
||
/** | ||
* @notice Constructs new Adapter. |
// ArbRetryableTx.getSubmissionPrice). ArbRetryableTicket precompile interface exists at L2 address | ||
// 0x000000000000000000000000000000000000006E. | ||
// The Arbitrum Inbox requires that this uses 18 decimal precision. | ||
uint256 public immutable L2_MAX_SUBMISSION_COST; | ||
Check warning on line 48 in contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol
|
||
// L2 Gas price bid for immediate L2 execution attempt (queryable via standard eth*gasPrice RPC) | ||
// The Arbitrum Inbox requires that this is specified in gWei (e.g. 1e9 = 1 gWei) | ||
uint256 public immutable L2_GAS_PRICE; | ||
Check warning on line 52 in contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol
|
||
// Native token expected to be sent in L2 message. Should be 0 for most use cases of this constant. This | ||
// constant is unused when sending the native gas token over the inbox since the inbox interprets `l2CallValue` | ||
// The number of decimals of precision for the custom gas token. This is defined in the constructor and not dynamically fetched since decimals are | ||
// not part of the standard ERC20 interface. | ||
uint8 public immutable NATIVE_TOKEN_DECIMALS; | ||
Check warning on line 66 in contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol
|
||
// This address on L2 receives extra gas token that is left over after relaying a message via the inbox. | ||
address public immutable L2_REFUND_L2_ADDRESS; | ||
Check warning on line 69 in contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol
|
||
// Inbox system contract to send messages to Arbitrum. Token bridges use this to send tokens to L2. | ||
// https://github.com/OffchainLabs/nitro-contracts/blob/f7894d3a6d4035ba60f51a7f1334f0f2d4f02dce/src/bridge/Inbox.sol | ||
ArbitrumL1InboxLike public immutable L1_INBOX; | ||
Check warning on line 73 in contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol
|
||
// Router contract to send tokens to Arbitrum. Routes to correct gateway to bridge tokens. Internally this | ||
// contract calls the Inbox. | ||
// Generic gateway: https://github.com/OffchainLabs/token-bridge-contracts/blob/main/contracts/tokenbridge/ethereum/gateway/L1ArbitrumGateway.sol | ||
// Gateway used for communicating with chains that use custom gas tokens: | ||
// https://github.com/OffchainLabs/token-bridge-contracts/blob/main/contracts/tokenbridge/ethereum/gateway/L1ERC20Gateway.sol | ||
ArbitrumL1ERC20GatewayLike public immutable L1_ERC20_GATEWAY_ROUTER; | ||
Check warning on line 80 in contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol
|
||
// This token is used to pay for l1 to l2 messages if its configured by an Arbitrum orbit chain. | ||
IERC20 public immutable CUSTOM_GAS_TOKEN; | ||
Check warning on line 83 in contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol
|
||
// Contract that funds Inbox cross chain messages with the custom gas token. | ||
FunderInterface public immutable CUSTOM_GAS_TOKEN_FUNDER; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning these into double slashes doesn't remove them from docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should remove them from the docs, aren't they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, yes, before your change, Anchor was adding
program).
to the documentation.Now, it doesn’t add documentation for this account (expected behavior).
Before your fix:
After fix:
All good!