fix(svm): L-05 comment on efficient handler_signer PDA derivation #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OZ identified following issue:
Storing the bump would require passing additional state account with
HandleV3AcrossMessage
. The depositor should then encode the message by prepending this state account to all other accounts required for all inner CPIs, but that would not be compatible with lamports value transfers to the first account when value > 0. To resolve that would require extending theAcrossPlusMessage
struct to distinguish between static accounts that are passed tohandle_v3_across_message
(currently we have none) from all remaining accounts that are used in inner CPIs. This would mean longer message size and more complexity for both the depositors and fillers.As an alternative measure, it is proposed for the deployer to choose such handler program ID so to minimize the resulting computational cost of finding the PDA for the
handler_signer
making sure that its bump is the maximum value of 255. This PR adds a comment on program ID on this consideration.