feat(marketing): blog site #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
src/app/_lib/contentful.ts
Outdated
| content_type: contentType, | ||
| limit, | ||
| "fields.content[exists]": true, // no empty posts | ||
| "fields.tag[in]": tags.join(","), // get posts with same tags |
There was a problem hiding this comment.
be careful here: this is case sensitive. So, for example, the string uma will not match any entries if the tag is UMA on contentful.
There was a problem hiding this comment.
Great callout +1
gsteenkamp89
approved these changes
Aug 21, 2024
| // TODO: test this, make custom component if necessary | ||
| case "video": | ||
| return ( | ||
| <video title={title} aria-description={description} src={file?.url}> |
There was a problem hiding this comment.
I think the src here also needs the protocol, same as in<ContentfulImage />.
const urlWithProtocol = `https:${file?.url}`;Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
dohaki
approved these changes
Aug 22, 2024
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
added a commit
that referenced
this pull request
Oct 1, 2024
* feat(blog page): wip Signed-off-by: james-a-morris <[email protected]> * chore: breakup to component parts Signed-off-by: james-a-morris <[email protected]> * feat: addtl components Signed-off-by: james-a-morris <[email protected]> * chore: fix bug Signed-off-by: james-a-morris <[email protected]> * fix: url on vercel Signed-off-by: james-a-morris <[email protected]> * improve: addtl components Signed-off-by: james-a-morris <[email protected]> * chore: additional elements Signed-off-by: james-a-morris <[email protected]> * chore: rename components Signed-off-by: james-a-morris <[email protected]> * chore: add metatags Signed-off-by: james-a-morris <[email protected]> * chore: send to twitter url Signed-off-by: james-a-morris <[email protected]> * chore: lowercase tabs Signed-off-by: james-a-morris <[email protected]> * chore: video link with protocol identifier Signed-off-by: james-a-morris <[email protected]> * chore: remove dynamic call Signed-off-by: james-a-morris <[email protected]> --------- Signed-off-by: james-a-morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces individual blog pages - it's recommended to use
/blog/timto find an example of a specific blog page.