Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(amplitude): instrument bridge buttons #40

Merged

Conversation

james-a-morris
Copy link
Contributor

This PR is aimed at instrumenting the bridge button clicks with a custom event. In order to get the environment configured to add this event, the Amplitude tracking had to be converted to a provider/context model.

Copy link

linear bot commented Apr 5, 2024

@james-a-morris james-a-morris requested a review from dohaki April 5, 2024 18:30
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
across-to ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 4:33pm

Copy link
Collaborator

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Left two small nits

@james-a-morris james-a-morris merged commit 673d699 into master Apr 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants