-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-1473: Pull default site if non-interactive. #1839
base: main
Are you sure you want to change the base?
Conversation
If your site has multiple databases, acli pull:db --no-interaction will not pull the default database, which is the logical default.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
=========================================
Coverage 92.91% 92.91%
- Complexity 1845 1846 +1
=========================================
Files 123 123
Lines 6960 6963 +3
=========================================
+ Hits 6467 6470 +3
Misses 493 493 ☔ View full report in Codecov by Sentry. |
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1839/acli.phar
|
The same is apparently true with pulling files. @danepowell We'd love your review of Is any of this behavior new, or did nobody ever pipe up before? |
First time I've ever seen an escaped mutant!
|
Thanks for the PR! I'd prefer to solve this slightly differently so that the question prompt reflects the default, e.g.:
|
@rfay mutation testing is amazing! In this case, it pointed out a potential bug with array_merge, if the array returned by @charginghawk and @rfay please test and let me know if this works for you. You can download a dev build following the instructions in this comment: #1839 (comment) |
If your site has multiple databases, acli pull:db --no-interaction will not pull the default database, which is the logical default.
Motivation
Ran into this issue using
ddev pull acquia
on a site with multiple databases.https://github.com/ddev/ddev/blob/master/pkg/ddevapp/dotddev_assets/providers/acquia.yaml#L53
It wasn't pulling the default, which I would expect.
Proposed changes
Use the default site when non-interactive.
Alternatives considered
Testing steps
Try
acli pull:db --no-interaction
on a site with multiple databases../bin/acli ckc