This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
enhance: add the ability to require compute classes #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oscar Ward <[email protected]>
keyallis
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42,
g-linville and
tylerslaton
added 4 commits
February 12, 2024 09:53
Signed-off-by: Oscar Ward <[email protected]>
Signed-off-by: Oscar Ward <[email protected]>
Signed-off-by: Oscar Ward <[email protected]>
Signed-off-by: Oscar Ward <[email protected]>
thedadams
suggested changes
Feb 12, 2024
Signed-off-by: Oscar Ward <[email protected]>
thedadams
approved these changes
Feb 12, 2024
| @@ -209,7 +209,8 @@ func (s *Validator) Validate(ctx context.Context, obj runtime.Object) (result fi | |||
| project, | |||
| workloadsFromImage, | |||
| apiv1cfg.WorkloadMemoryDefault, | |||
| apiv1cfg.WorkloadMemoryMaximum) | |||
| apiv1cfg.WorkloadMemoryMaximum, | |||
| apiv1cfg.RequireComputeClass) | |||
There was a problem hiding this comment.
nit: putting this here means this only happens once.
Suggested change
| apiv1cfg.RequireComputeClass) | |
| z.Dereference(apiv1cfg.RequireComputeClass), | |
| ) |
Signed-off-by: Oscar Ward <[email protected]>
tylerslaton
approved these changes
Feb 12, 2024
Signed-off-by: Oscar Ward <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acorn-io/manager#1819
Add a new install config flag to require compute classes for workloads to be scheduled.
Checklist
This is a title (#1216). Here's an example