Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin view resumes page #248

Merged
merged 4 commits into from
May 5, 2024
Merged

Admin view resumes page #248

merged 4 commits into from
May 5, 2024

Conversation

SheepTester
Copy link
Member

Info

Closes #223.

view resumes page

Changes

  • view resumes page

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

image
image

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 10:52pm
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 10:52pm

Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should there be pagination on this page? on prod we have 44 resumes

down the line we should also support downloading all the resumes as a .zip, since that's the main use case of this page (to get all the resumes and send to companies as part of sponsorship package)

@SheepTester
Copy link
Member Author

image

okay i added a zip all button

@SheepTester
Copy link
Member Author

image
image

got approval

@SheepTester SheepTester merged commit 8219c00 into main May 5, 2024
8 checks passed
@SheepTester SheepTester deleted the sean/view-resumes branch May 5, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin - View User Resumes
2 participants