Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File name verifier #1451

Merged
merged 6 commits into from
Jan 16, 2025
Merged

File name verifier #1451

merged 6 commits into from
Jan 16, 2025

Conversation

MontrealSergiy
Copy link
Contributor

@MontrealSergiy MontrealSergiy commented Nov 27, 2024

To reduce integration experts confusion, module is renamed
File Name Verifier in same vein with the File Name Matcher . See #1447 for details

@MontrealSergiy MontrealSergiy added the Boutiques Boutiques integration label Nov 27, 2024
@MontrealSergiy MontrealSergiy self-assigned this Nov 27, 2024
@MontrealSergiy MontrealSergiy linked an issue Nov 27, 2024 that may be closed by this pull request
@MontrealSergiy
Copy link
Contributor Author

Test boutiques file_name_check.json

@MontrealSergiy
Copy link
Contributor Author

Correcting

# "default-value": "xcpd_output"
# }
#
# "cbrain:integrator_modules": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the JSON a bit further, int he comment block it now starts at the same level as the text, so it would not be rendered as a code block in the auto doc.

Copy link
Contributor Author

@MontrealSergiy MontrealSergiy Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 38-47 were deleted as per a previous comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. I mean the JSON is not indented properly anymore.

# "default-value": "xcpd_output"
# }
#
# "cbrain:integrator_modules": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. I mean the JSON is not indented properly anymore.

@prioux prioux merged commit 057739d into aces:master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Boutiques Boutiques integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Boutiques module to validate strings used as filenames
2 participants