OpenID integration. #1412
Merged
OpenID integration. #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 038a151 Author: Natacha Beck <[email protected]> Date: Wed Jul 17 13:42:00 2024 -0400 [FIX] after PR revDate: Mon Jul 15 12:25:08 2024 -0400 Update nh_mandatory_oidc.html.erb (About 60 commits here) commit 9f9963b Author: natacha-beck <[email protected]> Date: Wed May 22 04:24:49 2024 -0400 [WIP] 1st version of keycloak integration
Closed
Major updates to Natacha's OIDC code.
prioux
reviewed
Jul 23, 2024
| @oidc_configs = OidcConfig.all | ||
| # Hash of OIDC uris with the OIDC name as key | ||
| @oidc_uris = generate_oidc_login_uri(@oidc_configs, globus_url) | ||
|
|
There was a problem hiding this comment.
Note for POST merge: these changes are unnecessary.
prioux
reviewed
Jul 23, 2024
| @@ -266,6 +288,8 @@ def create_from_user(user, origin='CBRAIN') #:nodoc: | |||
| # Send a proper HTTP error code | |||
| # when a user has not properly authenticated | |||
| def auth_failed | |||
| # Array of enabled OIDC providers configurations | |||
| @oidc_configs = OidcConfig.all | |||
There was a problem hiding this comment.
I think we're missing the hash of URLS here?
prioux
reviewed
Jul 23, 2024
| @@ -21,6 +21,7 @@ | |||
| # | |||
|
|
|||
| require 'ipaddr' | |||
| require 'oidc_config' | |||
prioux
reviewed
Jul 23, 2024
| Learn more at <%= link_to oidc.help_label, oidc.help_uri, :class => "globus_home_link" %> | ||
| </p> | ||
| <% end %> | ||
| <% else %> |
There was a problem hiding this comment.
The indentation seems wrong here?
|
I will merge this and then make some more modifications as an extra commit on master. |
prioux
added
Enhancement
User Interface
Refactoring
Priority: Normal
Admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 038a151
Author: Natacha Beck [email protected]
Date: Wed Jul 17 13:42:00 2024 -0400
(About 60 commits here)
commit 9f9963b
Author: natacha-beck [email protected]
Date: Wed May 22 04:24:49 2024 -0400