Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation error with only other for outcome analysis (resolves #2057) #2104

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Jan 18, 2024

Resolves #2057

  • Allows specifying only an "other" for Who will be going through the results and producing an outcome?
  • Updates publishable check to allow the project to be publishable in the above case
  • Extends test coverage for validation errors related to project requests
  • Addresses some issues found with the request validation when adding the tests

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara jobara added this to the 1.3.0 milestone Jan 18, 2024
@jobara jobara mentioned this pull request Jan 18, 2024
60 tasks
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4f8c3f) 97.60% compared to head (c37d4bc) 97.65%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #2104      +/-   ##
============================================
+ Coverage     97.60%   97.65%   +0.04%     
- Complexity     2101     2103       +2     
============================================
  Files           313      313              
  Lines          9522     9535      +13     
============================================
+ Hits           9294     9311      +17     
+ Misses          228      224       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobara jobara merged commit 0458cf9 into accessibility-exchange:dev Jan 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant