Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openssl support in univers #42

Merged
merged 3 commits into from
Mar 13, 2022
Merged

Add openssl support in univers #42

merged 3 commits into from
Mar 13, 2022

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space commented Feb 21, 2022 •
edited
Loading

Hritik14
Hritik14 requested changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@Hritik14 Hritik14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the research on openssl!! There are a few things that I'd like you to consider...

src/univers/version_constraint.py Outdated Show resolved Hide resolved
src/univers/version_constraint.py Outdated Show resolved Hide resolved
src/univers/version_range.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
@keshav-space keshav-space force-pushed the main branch 4 times, most recently from 228fc29 to cf36b09 Compare March 9, 2022 18:46
@keshav-space
Add openssl support in univers
6f03cf6 
- closes aboutcode-org#36
- For `OpenSSL-FIPS Module` see aboutcode-org#41

Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space keshav-space requested a review from Hritik14 March 9, 2022 19:06
pombredanne
pombredanne requested changes Mar 9, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++
See some comments inline for your consideration.

src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Show resolved Hide resolved
pombredanne
pombredanne requested changes Mar 10, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey :) I added a few more comments... also I did unresolve a few of the comments you had marked as resolved as I could not see the corresponding change applied... I realize now thst this may be just because you have not pushed your changes yet?

src/univers/version_range.py Outdated Show resolved Hide resolved
src/univers/version_range.py Outdated Show resolved Hide resolved
src/univers/version_range.py Outdated Show resolved Hide resolved
src/univers/version_range.py Outdated Show resolved Hide resolved
src/univers/version_range.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
src/univers/versions.py Outdated Show resolved Hide resolved
pombredanne
pombredanne reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you merge the latest main back in your branch the tests should not run anymore on older mac/linux/windows (and should therefore no longer fail)

@keshav-space keshav-space mentioned this pull request Mar 11, 2022
Open
@keshav-space
add test for openssl
0ff5a9c 
Signed-off-by: Keshav Priyadarshi <[email protected]>
pombredanne
pombredanne approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. We can merge as is...Thank you ++
Can you please add an issue to add an extra test that would use the list of all the OpenSSL version ever released to date and ensure that sorting this list gives the correct order?

@keshav-space
Copy link
Member Author

Looking great. We can merge as is...Thank you ++ Can you please add an issue to add an extra test that would use the list of all the OpenSSL version ever released to date and ensure that sorting this list gives the correct order?

Yeah, I will raise an issue for that.

@pombredanne pombredanne merged commit 55372de into aboutcode-org:main Mar 13, 2022
@keshav-space keshav-space mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@Hritik14 Hritik14 Awaiting requested review from Hritik14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new version range for "openssl"
3 participants
@keshav-space @pombredanne @Hritik14