Rewritten assert statements for more explicit checks #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a reference link in your commit message before your signoff: |
pombredanne
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Thanks, can you amend your commit to add your DCO signoff?
Note that the other test failures may not be your making, but rather because of #576
|
@pombredanne |
pombredanne
reviewed
Jan 23, 2025
| @@ -193,8 +193,19 @@ def generate_sctk_input(abouts, min_license_score, license_dict): | |||
| for key in lic_key: | |||
| lic_name.append(license_dict[key][0]) | |||
| lic_score = about.license_score.value | |||
| assert len(lic_key) == len(lic_name) | |||
| assert len(lic_key) == len(lic_score) | |||
| if len(lic_key) != len(lic_name): | |||
There was a problem hiding this comment.
May be you can extract a variable?
Suggested change
| if len(lic_key) != len(lic_name): | |
| len_lics = len(lic_key) | |
| if len_lics != len(lic_name): |
and then use it in the messages and other tests below?
pombredanne
requested changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
I have changed the assert statements to if and raise statements. It was a good first issue.