-
-
Notifications
You must be signed in to change notification settings - Fork 132
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix reader syntaxes distrupted by newlines
Lispy would assume an implicit nil after the reader syntax, like this: ```emacs-lisp (defun foo () ' (bar baz) ) ;; point here, press i to format ``` Gets this incorrect result: ```emacs-lisp (defun foo () '() (bar baz)) ``` * lispy.el (lispy--delete-insignificant-sexps): allow removing sexps that are implicitly-created by lispy, and serve no purpose in the real input and output sexp other than formatting. At the moment, just remove newline nodes. (lispy--read-reader-syntax): helper function to avoid code duplication; replaces a reader syntax RS, e.g., "`", plus its immediately-next sexp into an internal representation with TAG. (lispy--read): update handling of "#'", ",@", "'", "`", "," to make use of `lispy--read-reader-syntax'. (lispy--insert): fixed float and quasiquote handling (currently it calls `(insert (caddr sxp))', which is incorrect because `insert' considers it a character; float was not problematic because this code path was never triggered: things like 1.2 have not been converted into `ly-raw float' constructs anyway. * lispy-test.el (lispy-read-quote-newline): added 5 simple tests for each of the addressed reader syntaxes.
- Loading branch information
Showing
2 changed files
with
64 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters