Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3732] Make realtime presence functionality tree-shakable #1428

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[SDK-3732] Make realtime presence functionality tree-shakable #1428

merged 1 commit into from
Nov 21, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Aug 23, 2023 •
edited
Loading

Note: This PR is based on top of #1425; please review that one first.

We move the realtime presence functionality into a tree-shakable RealtimePresence module.

Resolves #1375.

@github-actions github-actions bot temporarily deployed to staging/pull/1428/features August 23, 2023 12:03 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report August 23, 2023 12:03 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc August 23, 2023 12:04 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review August 23, 2023 13:30
@lawrence-forooghian lawrence-forooghian mentioned this pull request Aug 23, 2023
Merged
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from 1931f45 to 73c9b5f Compare August 23, 2023 14:41
@github-actions github-actions bot temporarily deployed to staging/pull/1428/features August 23, 2023 14:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc August 23, 2023 14:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report August 23, 2023 14:42 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1375-msgpack-tree-shaking branch from 6766766 to 3a4867d Compare August 23, 2023 19:36
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from 73c9b5f to 39fa2cd Compare August 23, 2023 19:37
@github-actions github-actions bot temporarily deployed to staging/pull/1428/features August 23, 2023 19:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc August 23, 2023 19:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report August 23, 2023 19:38 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from 39fa2cd to d364b86 Compare September 5, 2023 08:38
@github-actions github-actions bot temporarily deployed to staging/pull/1428/features September 5, 2023 08:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report September 5, 2023 08:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc September 5, 2023 08:40 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from d364b86 to 674c059 Compare September 14, 2023 12:53
@github-actions github-actions bot temporarily deployed to staging/pull/1428/features September 14, 2023 12:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc September 14, 2023 12:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report September 14, 2023 12:54 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from 674c059 to 78f0a35 Compare October 26, 2023 16:43
@github-actions github-actions bot temporarily deployed to staging/pull/1428/features October 26, 2023 16:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc October 26, 2023 16:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report October 26, 2023 16:44 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from 78f0a35 to c80ea79 Compare October 26, 2023 17:23
@github-actions github-actions bot temporarily deployed to staging/pull/1428/features October 26, 2023 17:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report October 26, 2023 17:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc October 26, 2023 17:25 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as draft November 1, 2023 18:32
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from c80ea79 to d0a9d7c Compare November 7, 2023 19:09
@github-actions github-actions bot temporarily deployed to staging/pull/1428/features November 7, 2023 19:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/typedoc November 7, 2023 19:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1428/bundle-report November 7, 2023 19:11 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review November 7, 2023 19:59
owenpearson
owenpearson requested changes Nov 9, 2023
View reviewed changes
src/platform/web/modules/presencemessage.ts Outdated Show resolved Hide resolved
test/common/modules/shared_helper.js Outdated Show resolved Hide resolved
Base automatically changed from 1375-msgpack-tree-shaking to integration/v2 November 9, 2023 15:40
@lawrence-forooghian
Make realtime presence functionality tree-shakable
7cbd6fc 
We move it into a tree-shakable RealtimePresence module.

Resolves #1375.
@lawrence-forooghian lawrence-forooghian force-pushed the 1393-realtime-presence-tree-shaking branch from d0a9d7c to 7cbd6fc Compare November 14, 2023 18:48
owenpearson
owenpearson approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lawrence-forooghian lawrence-forooghian merged commit b750df5 into integration/v2 Nov 21, 2023
11 checks passed
@lawrence-forooghian lawrence-forooghian deleted the 1393-realtime-presence-tree-shaking branch November 21, 2023 00:10
@lawrence-forooghian lawrence-forooghian mentioned this pull request Nov 21, 2023
Closed
@VeskeR VeskeR mentioned this pull request Mar 1, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subashcs subashcs subashcs left review comments

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawrence-forooghian @subashcs @owenpearson