Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the noencryption variant of the library in v2 #1499

Closed
lawrence-forooghian opened this issue Nov 13, 2023 · 2 comments
Closed

Remove the noencryption variant of the library in v2 #1499

lawrence-forooghian opened this issue Nov 13, 2023 · 2 comments
Assignees
@lawrence-forooghian

Comments

@lawrence-forooghian
Copy link
Collaborator

This has been superseded by the tree-shakable version of the library.
@lawrence-forooghian lawrence-forooghian self-assigned this Nov 13, 2023
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Nov 13, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3945

lawrence-forooghian added a commit that referenced this issue Nov 13, 2023
@lawrence-forooghian
Remove the noencryption variant of the library
0b52210 
This is superseded by not passing the Crypto module in the tree-shakable
variant of the library.

Resolves #1499.
@lawrence-forooghian lawrence-forooghian mentioned this issue Nov 13, 2023
Merged
@lawrence-forooghian
Copy link
Collaborator Author

Done in #1500.

VeskeR pushed a commit that referenced this issue Mar 22, 2024
@lawrence-forooghian
Remove the noencryption variant of the library
dc47992 
This is superseded by not passing the Crypto module in the tree-shakable
variant of the library.

Resolves #1499.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian