Skip to content

Commit

Permalink
Remove the noencryption variant of the library
Browse files Browse the repository at this point in the history
This is superseded by not passing the Crypto module in the tree-shakable
variant of the library.

Resolves #1499.
  • Loading branch information
lawrence-forooghian committed Nov 13, 2023
1 parent a9cc07d commit 0b52210
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 66 deletions.
1 change: 0 additions & 1 deletion .github/workflows/bundle-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
run: |
mkdir bundle-reports
npm run sourcemap -- --html bundle-reports/index.html
npm run sourcemap:noencryption -- --html bundle-reports/noencryption.html
- uses: aws-actions/configure-aws-credentials@v1
with:
aws-region: eu-west-2
Expand Down
12 changes: 0 additions & 12 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,18 +129,6 @@ module.exports = function (grunt) {
outfile: 'build/ably.min.js',
minify: true,
}),
esbuild.build({
...baseConfig,
entryPoints: ['src/platform/web-noencryption/index.ts'],
outfile: 'build/ably.noencryption.js',
}),

esbuild.build({
...baseConfig,
entryPoints: ['src/platform/web-noencryption/index.ts'],
outfile: 'build/ably.noencryption.min.js',
minify: true,
}),
]).then(() => {
console.log('esbuild succeeded');
done(true);
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
"format": "prettier --write --ignore-path .gitignore --ignore-path .prettierignore src test ably.d.ts webpack.config.js Gruntfile.js scripts/*.js docs/chrome-mv3.md",
"format:check": "prettier --check --ignore-path .gitignore --ignore-path .prettierignore src test ably.d.ts webpack.config.js Gruntfile.js scripts/*.js",
"sourcemap": "source-map-explorer build/ably.min.js",
"sourcemap:noencryption": "source-map-explorer build/ably.noencryption.min.js",
"modulereport": "node scripts/moduleReport.js",
"docs": "typedoc --entryPoints ably.d.ts --out docs/generated --readme docs/landing-page.md"
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/cdn_deploy.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ async function run() {
// Comma separated directories (relative to `path`) to exclude from upload
excludeDirs: 'node_modules,.git',
// Regex to match files against for upload
fileRegex: '^ably(\\.noencryption)?(\\.min)?\\.js$',
fileRegex: '^ably?(\\.min)?\\.js$',
...argv,
};

Expand Down
45 changes: 0 additions & 45 deletions src/platform/web-noencryption/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion test/common/globals/named_dependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ define(function () {
return (module.exports = {
// Ably modules
ably: { browser: 'build/ably', node: 'build/ably-node' },
'ably.noencryption': { browser: 'build/ably.noencryption' },
'vcdiff-decoder': {
browser: 'node_modules/@ably/vcdiff-decoder/dist/vcdiff-decoder',
node: 'node_modules/@ably/vcdiff-decoder',
Expand Down
2 changes: 0 additions & 2 deletions test/support/browser_file_list.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ window.__testFiles__.files = {
'build/ably-webworker.min.js': true,
'build/ably.js': true,
'build/ably.min.js': true,
'build/ably.noencryption.js': true,
'build/ably.noencryption.min.js': true,
'browser/lib/util/base64.js': true,
'node_modules/async/lib/async.js': true,
'node_modules/@ably/vcdiff-decoder/dist/vcdiff-decoder.js': true,
Expand Down
3 changes: 0 additions & 3 deletions test/support/browser_setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ require([(baseUrl + '/test/common/globals/named_dependencies.js').replace('//',
ably: {
exports: 'Ably',
},
'ably.noencryption': {
exports: 'Ably',
},
'browser-base64': {
exports: 'Base64',
},
Expand Down

0 comments on commit 0b52210

Please sign in to comment.