Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
TODO remove Add a couple of test failures
Browse files Browse the repository at this point in the history
lawrence-forooghian committed Dec 14, 2023
1 parent 45dbb33 commit b8de90b
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/realtime/channel.test.js
Original file line number Diff line number Diff line change
@@ -482,7 +482,7 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, helper, async
channel.whenState('attached', function () {
firedImmediately = true;
try {
expect(channel.state).to.equal('attached', 'whenState fired when attached');
expect(channel.state).to.equal('attached-nah', 'whenState fired when attached');
closeAndFinish(done, realtime);
} catch (err) {
closeAndFinish(done, realtime, err);
2 changes: 1 addition & 1 deletion test/rest/presence.test.js
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, helper, async
return msg.clientId == 'client_int';
});
expect(encodedMessage.data).to.deep.equal(decodedMessage.data, 'Verify message decoding works correctly');
expect(encodedMessage.encoding).to.equal(null, 'Decoding should remove encoding field');
expect(encodedMessage.encoding).to.equal(10, 'Decoding should remove encoding field');
expect(decodedMessage.encoding).to.equal(null, 'Decoding should remove encoding field');
expect(boolMessage.data).to.equal('true', 'should not attempt to parse string data when no encoding field');
expect(intMessage.data).to.equal('24', 'should not attempt to parse string data when no encoding field');

0 comments on commit b8de90b

Please sign in to comment.