Remove redundant static properties from BaseRealtime

These already exist in its superclass BaseClient.
ably · Nov 6, 2023 · 96f4cf8 · 96f4cf8
1 parent 89c0761
commit 96f4cf8
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 16 deletions.
diff --git a/src/common/lib/client/baserealtime.ts b/src/common/lib/client/baserealtime.ts
@@ -10,8 +10,6 @@ import { ChannelOptions } from '../../types/channel';
 import ClientOptions from '../../types/ClientOptions';
 import * as API from '../../../../ably';
 import ConnectionManager from '../transport/connectionmanager';
-import Platform from 'common/platform';
-import Message from '../types/message';
 import { ModulesMap } from './modulesmap';
 
 /**
@@ -45,10 +43,7 @@ class BaseRealtime extends BaseClient {
 
   static Utils = Utils;
   static ConnectionManager = ConnectionManager;
-  static Platform = Platform;
   static ProtocolMessage = ProtocolMessage;
-  static Message = Message;
-  static Crypto?: typeof Platform.Crypto;
 }
 
 class Channels extends EventEmitter {

diff --git a/src/platform/nativescript/index.ts b/src/platform/nativescript/index.ts
@@ -1,4 +1,5 @@
 // Common
+import BaseClient from '../../common/lib/client/baseclient';
 import { DefaultRest } from '../../common/lib/client/defaultrest';
 import { DefaultRealtime } from '../../common/lib/client/defaultrealtime';
 import Platform from '../../common/platform';
@@ -29,8 +30,7 @@ Platform.Config = Config;
 Platform.Transports = Transports;
 Platform.WebStorage = WebStorage;
 
-DefaultRest.Crypto = Crypto;
-DefaultRealtime.Crypto = Crypto;
+BaseClient.Crypto = Crypto;
 
 Logger.initLogHandlers();
 

diff --git a/src/platform/nodejs/index.ts b/src/platform/nodejs/index.ts
@@ -1,4 +1,5 @@
 // Common
+import BaseClient from '../../common/lib/client/baseclient';
 import { DefaultRest } from '../../common/lib/client/defaultrest';
 import { DefaultRealtime } from '../../common/lib/client/defaultrealtime';
 import Platform from '../../common/platform';
@@ -25,8 +26,7 @@ Platform.Config = Config;
 Platform.Transports = Transports;
 Platform.WebStorage = null;
 
-DefaultRest.Crypto = Crypto;
-DefaultRealtime.Crypto = Crypto;
+BaseClient.Crypto = Crypto;
 
 Logger.initLogHandlers();
 

diff --git a/src/platform/react-native/index.ts b/src/platform/react-native/index.ts
@@ -1,4 +1,5 @@
 // Common
+import BaseClient from '../../common/lib/client/baseclient';
 import { DefaultRest } from '../../common/lib/client/defaultrest';
 import { DefaultRealtime } from '../../common/lib/client/defaultrealtime';
 import Platform from '../../common/platform';
@@ -29,8 +30,7 @@ Platform.Config = Config;
 Platform.Transports = Transports;
 Platform.WebStorage = WebStorage;
 
-DefaultRest.Crypto = Crypto;
-DefaultRealtime.Crypto = Crypto;
+BaseClient.Crypto = Crypto;
 
 Logger.initLogHandlers();
 

diff --git a/src/platform/web-noencryption/index.ts b/src/platform/web-noencryption/index.ts
@@ -1,4 +1,5 @@
 // Common
+import BaseClient from '../../common/lib/client/baseclient';
 import { DefaultRest } from '../../common/lib/client/defaultrest';
 import { DefaultRealtime } from '../../common/lib/client/defaultrealtime';
 import Platform from '../../common/platform';
@@ -24,8 +25,7 @@ Platform.Config = Config;
 Platform.Transports = Transports;
 Platform.WebStorage = WebStorage;
 
-DefaultRest.Crypto = null;
-DefaultRealtime.Crypto = null;
+BaseClient.Crypto = null;
 
 Logger.initLogHandlers();
 

diff --git a/src/platform/web/index.ts b/src/platform/web/index.ts
@@ -1,4 +1,5 @@
 // Common
+import BaseClient from '../../common/lib/client/baseclient';
 import { DefaultRest } from '../../common/lib/client/defaultrest';
 import { DefaultRealtime } from '../../common/lib/client/defaultrealtime';
 import Platform from '../../common/platform';
@@ -27,8 +28,7 @@ Platform.Config = Config;
 Platform.Transports = Transports;
 Platform.WebStorage = WebStorage;
 
-DefaultRest.Crypto = Crypto;
-DefaultRealtime.Crypto = Crypto;
+BaseClient.Crypto = Crypto;
 
 Logger.initLogHandlers();
 

diff --git a/src/platform/web/modules.ts b/src/platform/web/modules.ts
@@ -28,7 +28,6 @@ Platform.Transports = Transports;
 Platform.WebStorage = WebStorage;
 
 BaseClient.Crypto = Crypto;
-BaseRealtime.Crypto = Crypto;
 
 Logger.initLogHandlers();