Skip to content

Commit

Permalink
Fix inflection of TransportNames enum name
Browse files Browse the repository at this point in the history
  • Loading branch information
lawrence-forooghian committed Oct 26, 2023
1 parent 61ab4e4 commit 6979737
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 17 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
enum TransportNames {
enum TransportName {
WebSocket = 'web_socket',
Comet = 'comet',
XhrStreaming = 'xhr_streaming',
XhrPolling = 'xhr_polling',
}

export default TransportNames;
export default TransportName;
10 changes: 5 additions & 5 deletions src/common/types/IDefaults.d.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import TransportNames from '../constants/TransportNames';
import TransportName from '../constants/TransportName';
import { RestAgentOptions } from './ClientOptions';

export default interface IDefaults {
connectivityCheckUrl: string;
defaultTransports: TransportNames[];
baseTransportOrder: TransportNames[];
transportPreferenceOrder: TransportNames[];
upgradeTransports: TransportNames[];
defaultTransports: TransportName[];
baseTransportOrder: TransportName[];
transportPreferenceOrder: TransportName[];
upgradeTransports: TransportName[];
restAgentOptions?: RestAgentOptions;
}
10 changes: 5 additions & 5 deletions src/platform/nodejs/lib/util/defaults.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import IDefaults from '../../../../common/types/IDefaults';
import TransportNames from '../../../../common/constants/TransportNames';
import TransportName from '../../../../common/constants/TransportName';

const Defaults: IDefaults = {
connectivityCheckUrl: 'https://internet-up.ably-realtime.com/is-the-internet-up.txt',
/* Note: order matters here: the base transport is the leftmost one in the
* intersection of baseTransportOrder and the transports clientOption that's supported. */
defaultTransports: [TransportNames.WebSocket],
baseTransportOrder: [TransportNames.Comet, TransportNames.WebSocket],
transportPreferenceOrder: [TransportNames.Comet, TransportNames.WebSocket],
upgradeTransports: [TransportNames.WebSocket],
defaultTransports: [TransportName.WebSocket],
baseTransportOrder: [TransportName.Comet, TransportName.WebSocket],
transportPreferenceOrder: [TransportName.Comet, TransportName.WebSocket],
upgradeTransports: [TransportName.WebSocket],
restAgentOptions: { maxSockets: 40, keepAlive: true },
};

Expand Down
10 changes: 5 additions & 5 deletions src/platform/web/lib/util/defaults.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import IDefaults from 'common/types/IDefaults';
import TransportNames from 'common/constants/TransportNames';
import TransportName from 'common/constants/TransportName';

const Defaults: IDefaults = {
connectivityCheckUrl: 'https://internet-up.ably-realtime.com/is-the-internet-up.txt',
/* Order matters here: the base transport is the leftmost one in the
* intersection of baseTransportOrder and the transports clientOption that's
* supported. */
defaultTransports: [TransportNames.XhrPolling, TransportNames.XhrStreaming, TransportNames.WebSocket],
baseTransportOrder: [TransportNames.XhrPolling, TransportNames.XhrStreaming, TransportNames.WebSocket],
transportPreferenceOrder: [TransportNames.XhrPolling, TransportNames.XhrStreaming, TransportNames.WebSocket],
upgradeTransports: [TransportNames.XhrStreaming, TransportNames.WebSocket],
defaultTransports: [TransportName.XhrPolling, TransportName.XhrStreaming, TransportName.WebSocket],
baseTransportOrder: [TransportName.XhrPolling, TransportName.XhrStreaming, TransportName.WebSocket],
transportPreferenceOrder: [TransportName.XhrPolling, TransportName.XhrStreaming, TransportName.WebSocket],
upgradeTransports: [TransportName.XhrStreaming, TransportName.WebSocket],
};

export default Defaults;

0 comments on commit 6979737

Please sign in to comment.