Skip to content

Commit

Permalink
fixup! fixup! fixup! fixup! fixup! Use endpoint as default connection…
Browse files Browse the repository at this point in the history
… option (ADR-119)
  • Loading branch information
surminus committed Jan 15, 2025
1 parent 90c9a2b commit f163aef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion ably/export_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func ApplyOptionsWithDefaults(o ...ClientOption) *clientOptions {
return applyOptionsWithDefaults(o...)
}

func EndpointFqdn(endpoint string) bool {
func IsEndpointFqdn(endpoint string) bool {
return isEndpointFQDN(endpoint)
}

Expand Down
10 changes: 5 additions & 5 deletions ably/options_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -441,9 +441,9 @@ func TestPaginateParams(t *testing.T) {
})
}

func TestEndpointFqdn(t *testing.T) {
assert.Equal(t, false, ably.EndpointFqdn("sandbox"))
assert.Equal(t, true, ably.EndpointFqdn("sandbox.example.com"))
assert.Equal(t, true, ably.EndpointFqdn("127.0.0.1"))
assert.Equal(t, true, ably.EndpointFqdn("localhost"))
func TestIsEndpointFQDN(t *testing.T) {
assert.Equal(t, false, ably.IsEndpointFQDN("sandbox"))
assert.Equal(t, true, ably.IsEndpointFQDN("sandbox.example.com"))
assert.Equal(t, true, ably.IsEndpointFQDN("127.0.0.1"))
assert.Equal(t, true, ably.IsEndpointFQDN("localhost"))
}

0 comments on commit f163aef

Please sign in to comment.