Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support net6.0,net7.0 and MAUI #1215

Merged
merged 72 commits into from
May 10, 2023
Merged

Support net6.0,net7.0 and MAUI #1215

merged 72 commits into from
May 10, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 15, 2023

@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 15, 2023 18:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 15, 2023 19:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 15, 2023 20:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 15, 2023 20:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 15, 2023 20:14 Inactive
@sacOO7 sacOO7 changed the title Feature/support net6.0 Feature/support net6.0/net7.0 Mar 15, 2023
@sacOO7 sacOO7 changed the title Feature/support net6.0/net7.0 Support net6.0 and net7.0 Mar 15, 2023
@sacOO7 sacOO7 added the enhancement New feature or improved functionality. label Mar 15, 2023
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Mar 15, 2023

TODO

  • Fix tests
  • Fix github workflow
  • Add agent headers
  • Test xamarin project
  • Update build script README, check for other README updates

@sacOO7 sacOO7 requested a review from marto83 March 15, 2023 20:51
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 15, 2023 21:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 17, 2023 06:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 17, 2023 07:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 17, 2023 08:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 17, 2023 09:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features March 17, 2023 09:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features April 17, 2023 06:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features April 17, 2023 06:06 Inactive
@sacOO7 sacOO7 requested review from ikbalkaya and AndyTWF April 17, 2023 13:34
Copy link

@AndyTWF AndyTWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - there are a few deprecation warnings at the bottom of the Files Changed on the PR (for net6/7), are these quick things we could fix before merging? :)

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 20, 2023

Looks good - there are a few deprecation warnings at the bottom of the Files Changed on the PR (for net6/7), are these quick things we could fix before merging? :)

Yes, I will check if they can be fixed 👍

@sacOO7 sacOO7 changed the title Support net6.0 and net7.0 Support net6.0,net7.0 and MAUI Apr 21, 2023
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of very minor comments based on just checking that the code looks sensible. I don't know enough about the dotnet platform to be able to comment on the build changes here unfortunately.

build-script/paket.references Show resolved Hide resolved
Copy link
Contributor

@marto83 marto83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. I've got a couple of minor updates, and if you decide maybe remove the enum :) but that's more a preference rather than a hard and fast rule.

CONTRIBUTING.md Outdated Show resolved Hide resolved
build-script/paket.references Show resolved Hide resolved
src/IO.Ably.Shared/Agent.cs Outdated Show resolved Hide resolved
src/IO.Ably.Shared/Agent.cs Show resolved Hide resolved
src/IO.Ably.Tests.Shared/Rest/AblyHttpClientSpecs.cs Outdated Show resolved Hide resolved
src/IO.Ably.Tests.Shared/Rest/AblyHttpClientSpecs.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features April 28, 2023 17:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features April 28, 2023 18:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features April 28, 2023 18:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1215/features April 29, 2023 18:14 Inactive
@sacOO7 sacOO7 requested a review from owenpearson May 2, 2023 13:33
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the dotnet platform stuff but the code changes LGTM 👍

@github-actions github-actions bot temporarily deployed to staging/pull/1215/features May 5, 2023 09:04 Inactive
Copy link
Contributor

@marto83 marto83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sacOO7
Copy link
Collaborator Author

sacOO7 commented May 10, 2023

Thanks @marto83 and @owenpearson for the review.

@sacOO7
Copy link
Collaborator Author

sacOO7 commented May 10, 2023

Merging the PR since all tests are passing : )

@sacOO7 sacOO7 merged commit 4d78097 into main May 10, 2023
@sacOO7 sacOO7 deleted the feature/support-net6.0 branch May 10, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
4 participants