-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support net6.0,net7.0 and MAUI #1215
Conversation
sacOO7
commented
Mar 15, 2023
•
edited
Loading
edited
- Updated netstandard project to include net6.0/net7.0 support.
- Fixed compilation errors due to net6.0/net7.0 inclusion.
- Added tests for net6.0/net7.0.
- Upgraded NetCore3.1 (out of support) test project to Net6 and Net7.
- Updated github workflow for respective platforms.
- Added OS specific agent headers
- Fixed Update release notes with .NET 6 status #1116
- Fixed Dependency .NET 3.1 (LTS) support ends in December 2022 #1153
- Fixed Support for .NET Multi-platform App UI (.NET MAUI) #1178
- Fixed .Net MAUI app throws System.Net.NetworkInformation.NetworkInformationException when creating AblyRealtime object #1205
TODO
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - there are a few deprecation warnings at the bottom of the Files Changed on the PR (for net6/7), are these quick things we could fix before merging? :)
Yes, I will check if they can be fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of very minor comments based on just checking that the code looks sensible. I don't know enough about the dotnet platform to be able to comment on the build changes here unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. I've got a couple of minor updates, and if you decide maybe remove the enum :) but that's more a preference rather than a hard and fast rule.
to run fake scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand the dotnet platform stuff but the code changes LGTM 👍
…om xamarin workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Thanks @marto83 and @owenpearson for the review. |
Merging the PR since all tests are passing : ) |