Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ably-js v2 migration #10

Merged
merged 5 commits into from
May 29, 2024
Merged

Ably-js v2 migration #10

merged 5 commits into from
May 29, 2024

Conversation

VeskeR
Copy link
Collaborator

@VeskeR VeskeR commented May 17, 2024

Updates this project to use ably-js v2 so it matches updated code samples in related blog post: https://ably.com/blog/realtime-chat-app-nextjs-vercel.

Additionally, this PR significantly changes README. The current version of the README in the repo is incredibly outdated as it tries to replicate the step-by-step guide mentioned above but contains very old information, referring to things that no longer exist in the project. Instead of spending a lot of time updating the README to match the current version of the post, I changed it to provide an overview of the project and explain what is needed to build, run, and deploy the app from this repo.

Also resolves #8

@VeskeR VeskeR requested a review from ttypic May 17, 2024 16:34
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-js-chat-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 1:13am

Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeskeR VeskeR changed the base branch from main to add-formatting May 24, 2024 03:53
@VeskeR VeskeR force-pushed the ably-js-v2-migration branch from 9f8753b to 1be2774 Compare May 24, 2024 03:55
@VeskeR
Copy link
Collaborator Author

VeskeR commented May 24, 2024

@ttypic I've updated formatting in #11 PR. This PR is now based on that formatting PR so please review that one too, thank you!

@VeskeR VeskeR force-pushed the ably-js-v2-migration branch from 89bb4fa to d0b0f00 Compare May 24, 2024 04:02
Base automatically changed from add-formatting to main May 29, 2024 01:15
@VeskeR VeskeR merged commit 7e17fa2 into main May 29, 2024
3 checks passed
@VeskeR VeskeR deleted the ably-js-v2-migration branch May 29, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename globals.css with global.css
2 participants