Bug: History saving empty commands

abhimanyubabbar · Aug 8, 2014 · 7226394 · 7226394
1 parent 43cd0ec
commit 7226394
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/example/content/example.css b/example/content/example.css
@@ -115,6 +115,10 @@ body {
     visibility:hidden;
 }
 
+.terminal-focused .terminal{
+    box-shadow: 0 0 20px rgba(217, 215, 255, 0.85) inset, 0px 0px 16px rgba(255, 255, 0, 0.5);
+}
+
 @media only screen and (max-device-width: 480px) {
     .container {
       width: 100%;

diff --git a/src/vtortola.ng-terminal.js b/src/vtortola.ng-terminal.js
@@ -230,6 +230,9 @@
 
         $scope.commandLine = '';
 
+        if (!command)
+            return;
+
         if (commandHistory.length > 10) {
             commandHistory.splice(0, 1);
         }

diff --git a/tests/spec/vtortola.ng-terminal.spec.js b/tests/spec/vtortola.ng-terminal.spec.js
@@ -55,6 +55,16 @@
                 scope.previousCommand();
                 expect(scope.commandLine).toEqual("RRR");
             });
+            it('Can skip empty commands', function () {
+                scope.keypress(82);
+                scope.keypress(82);
+                scope.keypress(82);
+                scope.execute();
+                scope.execute();
+                expect(scope.commandLine).toEqual("");
+                scope.previousCommand();
+                expect(scope.commandLine).toEqual("RRR");
+            });
             it('Can go forward in command history', function () {
                 scope.keypress(82);
                 scope.keypress(82);