Modify cache purging limit #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abbot this PR includes the unit tests. Let me know if you would like any updates! (especially w.r.t. eliminating the |
andig
reviewed
Oct 4, 2021
| @@ -79,7 +79,8 @@ func (da *DigestAuth) Purge(count int) { | |||
| } | |||
| cache := digestCache(entries) | |||
| sort.Sort(cache) | |||
| for _, client := range cache[:count] { | |||
There was a problem hiding this comment.
You could use min of count/len if you really want to remove count entries only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the authenticator's cache is purged, there was a consistent
slice bounds out of range [:200] with capacity 181panic occurring. Purging the entire cache resolves this error.This is moved over from #68, which is closed.