Fix issue-53 by increasing socket filter buffer from 14 bytes to 16 bytes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on master branch , i have bypassed failed CI job |
rzr
reviewed
Jan 19, 2025
rzr
reviewed
Jan 19, 2025
I think I have done that right?
That change actually belongs to my other PR which has already been accepted and merged (but wasn't rebased). I've addressed your comment in this PR as a second commit
I'm sorry, I am not sure what you mean by this. I will add more detail in the specific conversation for that line |
Prior to this fix, The stateChanged powered_on event will not arrive for bleno with an error called from setFilter (EINVAL, Invalid argument). The buffer for the socket filter was 14 bytes and is a constant value of the same length. However, AF_BLUETOOTH setsockopt kernel handler validates the len of the struct hci_filter and expects it to be bit aligned, zero padding (16 bytes), see abandonware/node-bluetooth-hci-socket#60 (comment) for more detail Additionally, change hardcoded literal '2902' in gatt peripheral initialisation for notify to use a constant string rather than string literal.
|
@rzr I have squashed & rebased now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.