Fixed WordPress theme API request that was failing. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also doing so removed a dependency and used curl instead to fetch the theme metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also doing so removed a dependency and used curl instead to fetch the theme metadata.
The problem for me was the
./updatescript was failing with an error message saying that an object was passed intostrleninside the request class. I started digging why it was failing and reached the point where I found that the API request to WordPress theme API was no longer working, it returned theAction not implementederror.I decided to see how it worked in the WordPress core and made it to work with a GET request instead of a POST request, getting rid of the Request class in the process. If you decide to merge this PR, the class can be removed from the code entirely, if it's not used anywhere outside this script.