Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI file for OutputDialog #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flying-sheep
Copy link
Contributor

Let’s try this again!

No idea why that spurious non-existing .ui file was referenced before, but it’s gone now.

@flying-sheep flying-sheep force-pushed the output-dialog-ui branch 3 times, most recently from 182edc6 to 784fd68 Compare May 11, 2017 08:10
@aarnt
Copy link
Owner

aarnt commented May 11, 2017

Hi flying-sheep.
You have to test the "Find" function in the new output dialog, because that was buggy before.
Try to search for words in the dialog, also pressing "Next" and "Previous" buttons.
The first PR I tested made octopi crash that time.

@flying-sheep flying-sheep force-pushed the output-dialog-ui branch 5 times, most recently from 3db7b79 to 09ca420 Compare May 13, 2017 13:36
@flying-sheep
Copy link
Contributor Author

flying-sheep commented May 13, 2017

OK, done!

i also added a menu item + shortcut to show the search bar (even though shortcuts in octopi don’t seem to work at all for me right now)

@MelloHut
Copy link

Can octopi have a gui like app store? I mean octopi is where we can download apps needed or wanted to have on the computer e.g LibreOffice. but could it possible that octopi softwares be available on icons type?

@flying-sheep
Copy link
Contributor Author

@MelloHut this is not the right place to discuss that, please file a new issue under https://github.com/aarnt/octopi/issues/new

@aarnt i think this is ready to merge and doesn’t break anything anymore 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants