Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to z-docker-opam example #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mostafatouny
Copy link
Contributor

@mostafatouny mostafatouny commented Jan 17, 2025

Modifications to Dockerfile fixes the following

json argument and casing.

Screenshot_2025-01-17_13-17-02

missing os package gmp-dev

Screenshot_2025-01-17_13-09-50

/usr/bin not found.

I lost the screenshot ;).

it is recommended to execute binaries using sh or ash in alpine; it has no bash out of the box.

COPY is more readable over ADD.

hello-opam.opam is not in the repo. probably a typo of z-docker-opam.opam file.

Docker compose is mentioned in another example. So we don't use it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant