-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numberOfLines, lineHeight options; create flatSizes; increase accuracy #37
Open
hsource
wants to merge
11
commits into
aMarCruz:master
Choose a base branch
from
wanderlog:wanderlog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsource
changed the title
Add numberOfLines parameter to limit number of lines
Add numberOfLines and lineHeight options
Mar 30, 2022
hsource
commented
Apr 5, 2022
hsource
commented
Apr 5, 2022
hsource
changed the title
Add numberOfLines and lineHeight options
Add numberOfLines and lineHeight options; create flatSizes
May 3, 2022
hsource
changed the title
Add numberOfLines and lineHeight options; create flatSizes
Add numberOfLines, lineHeight options; create flatSizes; increase accuracy
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some Text components that
numberOfLines
prop to limit lineslineHeight
style to change from the default line heightWe want to measure their height using
flatHeights
.This also increases accuracy for both iOS and Android by fixing tiny discrepancies.
Fix
numberOfLines
andflatHeights
. This matches the<Text numberOfLines={...}>
propflatSizes
function that behaves the same asflatHeights
, but returns both the width and height. We use arrays (instead of objects with width and height) to reduce the amount key data passed over the React Native bridgeTesting
Created Storybook story in our app to test it on both Android and iOS: