Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay message #46

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Add delay message #46

merged 7 commits into from
Oct 17, 2024

Conversation

NickGreen
Copy link
Contributor

Adds delay message to the update message box for each eligible plugin on the plugins page.
Displays date in format as set in the site settings, in UTC.

Screenshot 2024-10-10 at 12 39 40

@georgestephanis
Copy link

I'm not certain on the wording -- I think my brain would prefer the append as something like Version ##.## will not autoupdate until at least MM/DD/YY or the like -- I appreciate how we're using the site's options for date and time format -- but I'm largely going to defer to TAMs for how they feel the wording would work best for partners.

@NickGreen
Copy link
Contributor Author

Updated the wording as per TAM suggestion.

@georgestephanis @ecairol Would either of you dudes be willing to take a look at the code to make sure it's right and safe, before we merge it and send it off to a bunch of sites? :)

Copy link
Contributor

@ecairol ecairol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a couple of comments.

…vated

e.g. If not connected to WC.com, updates for paid plugins won't be available, so we shouldn't show the autoupdated message. Also, plugins won't autoupdate if deactivated, so no message.
@NickGreen
Copy link
Contributor Author

Also added checks to not show the message if:

  1. Autoupdates aren't available (i.e. wc.com isn't connected, so paid plugins can't update)
  2. Plugin is deactivated (autoupdates don't happen when plugins aren't active)

Tested, merging.

@NickGreen NickGreen merged commit 29c115c into trunk Oct 17, 2024
@NickGreen NickGreen deleted the add-delay-message branch October 17, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants