Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let degenerate intersections work for really short roads, and don't draw #245

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

dabreegster
Copy link
Contributor

draw sidewalk corners for pairs of just-sidewalks

Before:
image

After:
image

The resulting geometry is not great sometimes, but this is still an improvement over failing outright. #243 tracks doing something better. Right now, the generalized trim-to-corners algorithm looks for collisions between adjacent pairs of road-edges. We also have cases where one road edge intersects the perpendicular of an adjacent road (both edges). One way to handle it might be an existing TODO in the code, "If there's no hit, consider extending both lines and seeing if they hit"

@dabreegster dabreegster merged commit 876555f into main Mar 22, 2024
@dabreegster dabreegster deleted the degenerate branch March 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant