Modernize the LTN tool's edits system #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Move a bunch of types into map_model, adding them to the edit commands (in a totally backwards incompatible way) 2) Rip out the ad-hoc proposal and undo system in the LTN tool, and just use MapEdits
basemap, from the perspective of MapEdits. This stops including existing objects in the save file, undo list, and count of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1079 for context. This PR makes the LTN app much less bespoke in how it handles edits to the map. Savefiles no longer include existing filters and crossings, only ones the user has modified!
There are some behavioral regressions/warts that I'm leaving for now, but will work on in smaller followups. This PR's changes were mostly made a few weeks ago in https://github.com/a-b-street/abstreet/tree/ltn_map_edits (see there for more granular commits), and the scope/complexity of the change has made it very hard for me to get things to a point for merging.
new_editscan't generate unique ones -- different directory!)I need to regenerate all maps with this change before merging. Also, there's a backwards incompatible change to map edits. I'm giving up on maintaining this for now; after switching to more future-proof GeoJSON in #995, I'll revisit this.