Initiator configuration options #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IBM H3171-S2 reports SCSI version 1 and supports both READ10 and READ6. But READ6 fails in weird ways. Changed the logic so that: 1) If InitiatorUseRead10 is specified in zuluscsi.ini, it forces the mode. 2) Otherwise READ10 support is detected by trying to run the command.
USB MSC drive can be configured as readonly by setting in .ini: [SCSI] InitiatorMSC = 1 # Needed to enable MSC mode with SD card present InitiatorMSCReadOnly = 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new .ini configuration options for initiator mode:
InitiatorMSCReadOnly: Prevents writes to the drive through USB MSC modeInitiatorUseRead10: Forces usage of either READ6 (setting 0) or READ10 (setting 1) SCSI command. If config option is not specified, the support is autodetected.The autodetection is added to resolve the #519 problems without having to do any configuration. The config option is provided in case we find some drive which totally freaks out on unknown commands, instead of gracefully returning error status.
@aperezbios I have tested this with the drives I have, but they all support READ10 command.
If you still have
Apple Quantum ProDrive 80Sand time to test it with initiator mode, that could be a good idea before merging this pull request.