-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Unified Notifications #290
base: main
Are you sure you want to change the base?
Conversation
…ract into feat/unified-notifications
Signed-off-by: jagadeeswaran-zipstack <[email protected]>
for more information, see https://pre-commit.ci
…ract into feat/unified-notifications
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, I have a few suggestions:
- Performance Considerations: This implementation processes a large number of keys for each session, which might lead to performance issues.
- Feature Flag: To mitigate potential impacts, consider implementing this under a feature flag. This allows for controlled rollouts and easy rollback if necessary.
…ract into feat/unified-notifications
…ract into feat/unified-notifications
|
Quality Gate passedIssues Measures |
What
Unified Notifications consists of the following changes:
Why
The unified notification changes were implemented to enhance UX. Users can now see log and notification messages in one place, and these messages are persisted for 1 hour.
How
Can this PR break any existing features. If yes please list of possible items. If no please exaplin why. (PS: Admins do not merge the PR without this section filled)
Yes, this PR can break existing features. The code changes have been made in quite a few existing modules, increasing the chances of regression.
Database Migrations
NA
Env Config
LOGS_EXPIRATION_TIME_IN_SECOND - This env variable stores the TTL in seconds. The default value is 3600 (1 hour).
Relevant Docs
NA
Related Issues or PRs
NA
Dependencies Versions
NA
Notes on Testing
NA
Screenshots
Checklist
I have read and understood the Contribution Guidelines.