Missing retry turnaround #2307
Merged
Missing retry turnaround #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shawn-zil
force-pushed
the
2306-retry-turnaround
branch
from
774e055 to
b962b64
Compare
|
Bencher Report| Branch | 2306-retry-turnaround |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,186.30 (-2.54%) | 1,605.72 (73.88%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 380.18 (-20.75%) | 684.42 (55.55%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,055.40 (+2.91%) | 5,173.31 (78.39%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 9.69 (+5.65%) | 11.55 (83.93%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a node can still theoretically sync up without this fix, given enough time, but it will be rather annoying to have to re-download all the pre-existing blocks because it missed the turnaround.
FWIW, I think that we should merge this and fix it into 0.6.1.