Issue #2242 load checkpoints as stream #2243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | users/richard/2242_load_checkpoints_as_stream |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,066.50 (-11.57%) | 1,594.86 (66.87%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 440.30 (-7.66%) | 676.68 (65.07%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,114.00 (+4.22%) | 5,178.23 (79.45%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.32 (+12.33%) | 11.59 (89.09%) |
There was a problem hiding this comment.
Please can we rebase once #2244 is merged? Sorry for letting main break
zilliqa/src/db.rs
Outdated
| let input = File::open(&temp_filename)?; | ||
|
|
||
| let mut reader = BufReader::with_capacity(128 * 1024 * 1024, input); // 128 MiB read chunks | ||
| let buf_reader: BufReader<File> = BufReader::new(File::open(input_filename)?); |
There was a problem hiding this comment.
I recall @bzawisto deliberately changing the buffer size to 128 MiB at some point in the past. Any reason not to keep it?
Suggested change
| let buf_reader: BufReader<File> = BufReader::new(File::open(input_filename)?); | |
| let buf_reader = BufReader::with_capacity(128 * 1024 * 1024, File::open(input_filename)?); // 128 MiB read chunks |
There was a problem hiding this comment.
No, though I don't think it's likely to particularly change anything any longer - a big BufReader probably helps when writing the result to disk but I'm not sure it helps much when reading, since the buffer cache will look ahead in any event. I did try to measure it, but restoring a mainnet checkpoint takes so long I gave up ... harmless, anyway, so done :-)
rrw-zilliqa
force-pushed
the
users/richard/2242_load_checkpoints_as_stream
branch
from
1c7f3b7 to
5522a8d
Compare
rrw-zilliqa
force-pushed
the
users/richard/2242_load_checkpoints_as_stream
branch
from
5522a8d to
b4b7a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2242