feat: implement eth_feeHistory API method. #2221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 1512-implement-eth_feehistory-to-support-type-2-transactions |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,067.70 (-13.98%) | 1,634.08 (65.34%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 446.00 (-10.91%) | 719.25 (62.01%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,130.60 (+5.04%) | 5,142.49 (80.32%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.34 (+13.62%) | 11.43 (90.51%) |
…ment-eth_feehistory-to-support-type-2-transactions
…ment-eth_feehistory-to-support-type-2-transactions
…ment-eth_feehistory-to-support-type-2-transactions
…ment-eth_feehistory-to-support-type-2-transactions
zilliqa/src/api/eth.rs
Outdated
| let mut params = params.sequence(); | ||
| let block_count: u64 = params.next()?; | ||
| let newest_block: BlockNumberOrTag = params.next()?; | ||
| let reward_percentiles: Option<Vec<f64>> = params.optional_next()?; |
There was a problem hiding this comment.
Suggested change
| let reward_percentiles: Option<Vec<f64>> = params.optional_next()?; | |
| let reward_percentiles: Vec<f64> = params.optional_next()?.unwrap_or_default(); |
to save the extra branching later?
There was a problem hiding this comment.
I believe we should avoid including reward in the response if reward_percentiles is absent. Doesn't this imply that we need at least one branch?
… fee history structure
…ment-eth_feehistory-to-support-type-2-transactions
…ment-eth_feehistory-to-support-type-2-transactions
…ment-eth_feehistory-to-support-type-2-transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.