Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: incorrect serialization #2011

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix: incorrect serialization #2011

merged 2 commits into from
Dec 13, 2024

Conversation

shawn-zil
Copy link
Contributor

@shawn-zil shawn-zil commented Dec 13, 2024

#1969 introduced a new configuration, but missed out a serialization, which breaks deployment with z2.

before:

api_servers = [[object], [object]]

after:

api_servers = [{ port = 4201, enabled_apis = [{ apis = ["blockNumber"], namespace = "eth" }] }, { enabled_apis = ["admin", "erigon", "eth", "net", "ots", "trace", "txpool", "web3", "zilliqa"], port = 4202 }]

@shawn-zil shawn-zil enabled auto-merge December 13, 2024 04:43
@shawn-zil shawn-zil disabled auto-merge December 13, 2024 04:59
@shawn-zil shawn-zil marked this pull request as draft December 13, 2024 04:59
Copy link
Contributor

github-actions bot commented Dec 13, 2024

🐰 Bencher Report

Branch1969-missing-api-servers
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
process-empty/process-empty📈 view plot
🚷 view threshold
9,553,200.00
(+2.93%)
10,682,537.29
(89.43%)
produce-full/produce-full📈 view plot
🚷 view threshold
2,020,200,000.00
(-14.26%)
3,164,045,136.26
(63.85%)
🐰 View full continuous benchmarking report in Bencher

@shawn-zil shawn-zil marked this pull request as ready for review December 13, 2024 05:10
@shawn-zil shawn-zil changed the title Fix: Missing serialization Fix: incorrect serialization Dec 13, 2024
@shawn-zil shawn-zil enabled auto-merge December 13, 2024 05:19
@shawn-zil shawn-zil requested review from frankmeds and removed request for frankmeds December 13, 2024 05:22
@shawn-zil shawn-zil added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit a73549c Dec 13, 2024
6 of 8 checks passed
@shawn-zil shawn-zil deleted the 1969-missing-api-servers branch December 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants