-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macos ci/cd on cmake, benchmark and benchmark_pr #437
Conversation
Maybe we can add also windows in the matrix, and remove the Windows Cmake file for CI/CD |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 97.58% 97.88% +0.29%
==========================================
Files 87 87
Lines 9492 10057 +565
Branches 0 666 +666
==========================================
+ Hits 9263 9844 +581
+ Misses 229 213 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idk how the |
we can try, then if don't work, we can review it |
ok should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
We are waiting #427 to merge the PR |
Sounds good :) |
Recommend by Zig in #433
Would love a review as well @ZigRazor