Add nullptr guard-check in comparision of shared ptr node and edge #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Clang's critical bug on the library where we're doing custom shared_ptr comparison with potentially null ptrs.
This will fix #433 but i think what we should also be doing is enforce nullptr safety on these custom operators on shared ptrs
This allows Clang on MacOS to pass all tests.
I added
to == operator in PointerHash()
@ZigRazor would love a review